Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

60 observed flow and stage data #61

Merged
merged 25 commits into from
Nov 26, 2024
Merged

60 observed flow and stage data #61

merged 25 commits into from
Nov 26, 2024

Conversation

zherbz
Copy link
Contributor

@zherbz zherbz commented Oct 23, 2024

Added functionality to acquire observed data from the hdf file for both reference line and point locations related to stage and flow.

@zherbz zherbz requested a review from thwllms October 23, 2024 17:21
@zherbz zherbz linked an issue Oct 23, 2024 that may be closed by this pull request
Observed flow and stage data #60
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/rashdf/plan.py 97.38% <100.00%> (+0.19%) ⬆️

thwllms
thwllms requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@thwllms thwllms left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky one! I don't think I've seen this part of the HDF before; it looks a little different from other sections. I'm not really familiar with using observed data in RAS. That lack of internal consistency makes this stuff hard. But the code is shaping up well! Let me know if there's anything in my comments that needs clarification.

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
src/rashdf/plan.py Outdated Show resolved Hide resolved
src/rashdf/plan.py Outdated Show resolved Hide resolved
src/rashdf/plan.py Outdated Show resolved Hide resolved
src/rashdf/plan.py Outdated Show resolved Hide resolved
src/rashdf/plan.py Outdated Show resolved Hide resolved
@zherbz
Copy link
Contributor Author

zherbz commented Nov 20, 2024

Thanks for the great feedback! Just addressed all comments and sent back your way.

@zherbz zherbz requested a review from thwllms November 20, 2024 22:39
thwllms
thwllms reviewed Nov 21, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
thwllms
thwllms reviewed Nov 21, 2024
View reviewed changes
src/rashdf/plan.py Outdated Show resolved Hide resolved
@thwllms
Copy link
Contributor

thwllms commented Nov 21, 2024

@zherbz:

  • Got some comments above still outstanding
  • Code coverage is failing, meaning that there are untested lines in your changes. Seems like these are error paths -- just need to add a couple tests to verify that the correct errors are raised under expected conditions

@zherbz
Copy link
Contributor Author

zherbz commented Nov 25, 2024

@zherbz:

  • Got some comments above still outstanding
  • Code coverage is failing, meaning that there are untested lines in your changes. Seems like these are error paths -- just need to add a couple tests to verify that the correct errors are raised under expected conditions

Additional tests added and now able to merge once approved

@zherbz zherbz requested a review from thwllms November 25, 2024 17:03
thwllms
thwllms reviewed Nov 26, 2024
View reviewed changes
src/rashdf/plan.py Outdated Show resolved Hide resolved
@zherbz zherbz requested a review from thwllms November 26, 2024 15:30
@thwllms thwllms merged commit 99c1139 into main Nov 26, 2024
5 checks passed
@thwllms thwllms deleted the 60-observed-flow-and-stage-data branch November 26, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thwllms thwllms thwllms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Observed flow and stage data
2 participants
@zherbz @thwllms